Fix FormatArgs storage when -Zthreads > 1#12567
Merged
bors merged 1 commit intorust-lang:masterfrom May 3, 2024
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Alexendoo
force-pushed
the
format-args-storage
branch
from
dcc2b5c to
3758163
Compare
Contributor
|
☔ The latest upstream changes (presumably #12624) made this pull request unmergeable. Please resolve the merge conflicts. |
Alexendoo
force-pushed
the
format-args-storage
branch
from
3758163 to
264a19e
Compare
flip1995
approved these changes
Apr 28, 2024
Member
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
This is a nice improvement of that code. One minor comment, otherwise LGTM. r=me once addressed.
Alexendoo
force-pushed
the
format-args-storage
branch
from
264a19e to
c187bff
Compare
Member
|
@bors r+ Thanks! |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Contributor
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
xxchan
added a commit
to risingwavelabs/risingwave
that referenced
this pull request
Jul 31, 2024
format_args: rust-lang/rust-clippy#12567 Signed-off-by: xxchan <xxchan22f@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11886
The initial way I thought of was a little gross so I never opened a PR for it, I thought of a nicer way today that no longer involves any
thread_locals orstaticsrustc_data_strucutres::sync::{Lrc, OnceLock}implementDynSend+DynSyncso we can pass them to the lint passes that need the storagechangelog: none
r? @flip1995