Skip to content

Speed up mpsc_stress test#104722

Merged
bors merged 1 commit intorust-lang:masterfrom
mejrs:stress
Nov 23, 2022
Merged

Speed up mpsc_stress test#104722
bors merged 1 commit intorust-lang:masterfrom
mejrs:stress

Conversation

@mejrs
Copy link
Copy Markdown
Contributor

@mejrs mejrs commented Nov 22, 2022

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Nov 22, 2022

Failed to set assignee to nico-abram: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Nov 22, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nico-abram (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 22, 2022
@compiler-errors
Copy link
Copy Markdown
Contributor

r? compiler

I'm guessing people in the windows ping group don't have bors rights

Copy link
Copy Markdown
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a couple of comments. But this looks fine.

Comment thread src/test/ui/threads-sendsync/mpsc_stress.rs Outdated
Comment thread src/test/ui/threads-sendsync/mpsc_stress.rs Outdated
Copy link
Copy Markdown
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@compiler-errors
Copy link
Copy Markdown
Contributor

@bors r=ChrisDenton

@bors
Copy link
Copy Markdown
Collaborator

bors commented Nov 22, 2022

📌 Commit f2830f2 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2022
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 22, 2022
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 22, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 22, 2022
Rollup of 7 pull requests

Successful merges:

 - rust-lang#101368 (Forbid inlining `thread_local!`'s `__getit` function on Windows)
 - rust-lang#102293 (Add powerpc64-ibm-aix as Tier-3 target)
 - rust-lang#104717 (Add failing test for projections used as const generic)
 - rust-lang#104720 (rustdoc: remove no-op CSS `.popover::before / a.test-arrow { display: inline-block }`)
 - rust-lang#104722 (Speed up mpsc_stress test)
 - rust-lang#104724 (Fix `ClosureKind::to_def_id`)
 - rust-lang#104728 (Use `tcx.require_lang_item` instead of unwrapping lang items)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0115969 into rust-lang:master Nov 23, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants