Add `Config::hash_untracked_state` callback by Alexendoo · Pull Request #116731 · rust-lang/rust

Alexendoo · 2023-10-14T14:32:32Z

For context, I'm looking to use late module passes in Clippy which unlike regular late passes run incrementally per module

However we have a config file which can change between runs, we need changes to that to invalidate the lint_mod query. This PR adds a side channel for us to hash some extra state into Options in order to do that

This does not make any changes to Clippy, I plan to do that in a PR to the Clippy repo along with some other required changes

An alternative implementation would be to add a new query to track this state and override the lint_mod query in Clippy to first call that

cc @rust-lang/clippy

rustbot · 2023-10-14T14:32:41Z

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

oli-obk · 2023-10-16T12:40:10Z

There's probably a way to design this more in line with the query system, but we can always redesign later. For now this seems really useful for drivers in general

@bors r+

bors · 2023-10-16T12:40:21Z

📌 Commit 59f6f04 has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-10-16T16:33:45Z

⌛ Testing commit 59f6f04 with merge 4af886f...

bors · 2023-10-16T18:57:14Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 4af886f to master...

rust-timer · 2023-10-16T21:53:32Z

Finished benchmarking commit (4af886f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 626.363s -> 627.067s (0.11%)
Artifact size: 305.53 MiB -> 305.59 MiB (0.02%)

Deserialize `Msrv` directly in `Conf` Gives the error a span pointing to the invalid config value Also puts `Conf` itself in the `OnceLock` rather than just the `Msrv` for [the `register_late_mod_pass` work](rust-lang/rust#116731) since it will be used from two different callbacks changelog: none

This is a callback used to track otherwise untracked state. It was added in rust-lang#116731 for Clippy. (It was originally named `hash_untracked_state`, and examples in the rustc-dev-guide still use that name.) The `StableHasher` argument is unused, and probably has never been used. There is a FIXME comment pointing this out, which was added more than a year ago. This commit removes the `StableHasher` callback argument. This also removes the need for `Options::untracked_state_hash`.

@bjorn3

…state, r=bjorn3 Simplify `Config::track_state`. This is a callback used to track otherwise untracked state. It was added in rust-lang#116731 for Clippy. (It was originally named `hash_untracked_state`, and examples in the rustc-dev-guide still use that name.) The `StableHasher` argument is unused, and probably has never been used. There is a FIXME comment pointing this out, which was added more than a year ago. This commit removes the `StableHasher` callback argument. This also removes the need for `Options::untracked_state_hash`. r? @bjorn3

@bjorn3

…orn3 Simplify `Config::track_state`. This is a callback used to track otherwise untracked state. It was added in #116731 for Clippy. (It was originally named `hash_untracked_state`, and examples in the rustc-dev-guide still use that name.) The `StableHasher` argument is unused, and probably has never been used. There is a FIXME comment pointing this out, which was added more than a year ago. This commit removes the `StableHasher` callback argument. This also removes the need for `Options::untracked_state_hash`. r? @bjorn3

@bjorn3

…orn3 Simplify `Config::track_state`. This is a callback used to track otherwise untracked state. It was added in rust-lang/rust#116731 for Clippy. (It was originally named `hash_untracked_state`, and examples in the rustc-dev-guide still use that name.) The `StableHasher` argument is unused, and probably has never been used. There is a FIXME comment pointing this out, which was added more than a year ago. This commit removes the `StableHasher` callback argument. This also removes the need for `Options::untracked_state_hash`. r? @bjorn3

@bjorn3

…orn3 Simplify `Config::track_state`. This is a callback used to track otherwise untracked state. It was added in rust-lang/rust#116731 for Clippy. (It was originally named `hash_untracked_state`, and examples in the rustc-dev-guide still use that name.) The `StableHasher` argument is unused, and probably has never been used. There is a FIXME comment pointing this out, which was added more than a year ago. This commit removes the `StableHasher` callback argument. This also removes the need for `Options::untracked_state_hash`. r? @bjorn3

@bjorn3

…orn3 Simplify `Config::track_state`. This is a callback used to track otherwise untracked state. It was added in rust-lang/rust#116731 for Clippy. (It was originally named `hash_untracked_state`, and examples in the rustc-dev-guide still use that name.) The `StableHasher` argument is unused, and probably has never been used. There is a FIXME comment pointing this out, which was added more than a year ago. This commit removes the `StableHasher` callback argument. This also removes the need for `Options::untracked_state_hash`. r? @bjorn3

This is a callback used to track otherwise untracked state. It was added in rust-lang#116731 for Clippy. (It was originally named `hash_untracked_state`, and examples in the rustc-dev-guide still use that name.) The `StableHasher` argument is unused, and probably has never been used. There is a FIXME comment pointing this out, which was added more than a year ago. This commit removes the `StableHasher` callback argument. This also removes the need for `Options::untracked_state_hash`.

rustbot assigned oli-obk Oct 14, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 14, 2023

This comment has been minimized.

Sign in to view

Add Config::hash_untracked_state callback

59f6f04

rust-cloud-vms Bot force-pushed the hash-untracked-state branch from f96a129 to 59f6f04 Compare October 14, 2023 15:55

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 16, 2023

bors merged commit 4af886f into rust-lang:master Oct 16, 2023

rustbot added this to the 1.75.0 milestone Oct 16, 2023

bors mentioned this pull request Oct 16, 2023

Implement rustc part of RFC 3127 trim-paths #115214

Merged

Alexendoo deleted the hash-untracked-state branch October 16, 2023 20:02

Veykril mentioned this pull request Oct 17, 2023

Pull upstream master 2023 10 17 ferrocene/ferrocene#54

Merged

Alexendoo mentioned this pull request Oct 18, 2023

Deserialize Msrv directly in Conf rust-lang/rust-clippy#11683

Merged

Alexendoo mentioned this pull request Nov 7, 2023

Move lint_store #117649

Merged

bjorn3 mentioned this pull request Nov 14, 2023

Remove Config::hash_untracked_state. #117897

Closed

nnethercote mentioned this pull request Apr 23, 2026

Simplify Config::track_state. #155671

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add `Config::hash_untracked_state` callback#116731

Add `Config::hash_untracked_state` callback#116731
bors merged 1 commit intorust-lang:masterfrom
Alexendoo:hash-untracked-state

Alexendoo commented Oct 14, 2023

Uh oh!

rustbot commented Oct 14, 2023

Uh oh!

This comment has been minimized.

oli-obk commented Oct 16, 2023

Uh oh!

bors commented Oct 16, 2023

Uh oh!

bors commented Oct 16, 2023

Uh oh!

bors commented Oct 16, 2023

Uh oh!

rust-timer commented Oct 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

Alexendoo commented Oct 14, 2023

Uh oh!

rustbot commented Oct 14, 2023

Uh oh!

This comment has been minimized.

oli-obk commented Oct 16, 2023

Uh oh!

bors commented Oct 16, 2023

Uh oh!

bors commented Oct 16, 2023

Uh oh!

bors commented Oct 16, 2023

Uh oh!

rust-timer commented Oct 16, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants