expand: Feature gate out-of-line modules in proc macro input#66078
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 4, 2019
Merged
expand: Feature gate out-of-line modules in proc macro input#66078bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Nov 4, 2019
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
r=me p=2 with comment addressed or not if short on time.
Contributor
Author
|
@bors r=Centril p=2 |
Collaborator
|
📌 Commit e7cedc9 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Nov 4, 2019
expand: Feature gate out-of-line modules in proc macro input Extracted from #64273. We are currently gating attributes applied directly to `mod` items because there are unresolved questions about out-of-line modules and their behavior is very likely to change. However, you can sneak an out-of-line module into an attribute macro input using modules nested into other items like ```rust #[my_attr] fn m() { #[path = "zzz.rs"] mod n; // what tokens does the `my_attr` macro see? } ``` This PR prevents that and emits a feature gate error for this case as well. r? @Centril It would be great to land this before beta.
Collaborator
|
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #64273.
We are currently gating attributes applied directly to
moditems because there are unresolved questions about out-of-line modules and their behavior is very likely to change.However, you can sneak an out-of-line module into an attribute macro input using modules nested into other items like
This PR prevents that and emits a feature gate error for this case as well.
r? @Centril
It would be great to land this before beta.