feat(cargo): Style help like cargo nightly#5908
Merged
ytmimi merged 3 commits intorust-lang:masterfrom Sep 12, 2023
Merged
Conversation
calebcartwright
approved these changes
Sep 11, 2023
Member
calebcartwright
left a comment
calebcartwright
left a comment
There was a problem hiding this comment.
lgtm, like the short and sweet ones!
@ytmimi - i can't recall the specifics but vaguely remember a semi-recent case where some change did something odd to our terminal coloring that you investigated. i'll defer merging this to you accordingly on the off chance there's anything you want to consider based on that (if not then feel free to bash the merge button!)
calebcartwright
added
pr-ready-to-merge
ytmimi
approved these changes
Sep 12, 2023
Contributor
ytmimi
left a comment
ytmimi
left a comment
There was a problem hiding this comment.
Updated output looks good to me, thanks!
calebcartwright
removed
the
pr-ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of rust-lang/cargo#12578, nightly cargo's help has terminal styling applied to it. This PR updates cargo-fmt to match so commands that appear built-in to the user all behave the same.
Other differences not address
cargo help fmt(and providing an accompanying man page to be shown instead)See rust-lang/cargo#12578 for screenshots of
cargoandcargo runwith different themes.