Misnamed function in collections/hashmap2.rs?

[dimitrijekostic]

Hello, my impression is that the at_least_five_types_of_fruits() test function on lines 67-72 (in the testing module for collections/hashmap2.rs) has a misleading name, and would be more accurately named exactly_five_types_of_fruits(). Or perhaps the body of the function should be different?

[Zerotask]

Hello @dimitrijekostic
it seems that you mean collections/hashmap1.rs.
At least is correct here since the body's assertion is >= 5. This means it results in a true if you have 5 or 10 or 500 fruits, everything which is 5 or greater.

[dimitrijekostic]

@Zerotask No, I'm referring to collections/hashmap2.rs. The hashmap exercises have similarly-named methods in them:
collections/hashmap1.rs has at_least_five_fruits()
collections/hashmap2.rs has at_least_five_types_of_fruits()
I'm referring to the latter. Note that at_least_five_types_of_fruits() contains an assert!(count_fruit_kinds == 5); which is not what the name of the method leads you to expect.

[Zerotask]

Oh, it seems I was a bit blind. :D You're right.

This is already fixed with #660

rustlings/exercises/collections/hashmap2.rs

Line 71 in 7cd635f

assert!(count_fruit_kinds >= 5);

[dimitrijekostic]

Very good, I guess I just need to do another pull. Thanks for looking into it!