Skip to content

Show version of rust being installed#1025

Merged
bors merged 4 commits intomasterfrom
db-show-manifest-version
May 29, 2017
Merged

Show version of rust being installed#1025
bors merged 4 commits intomasterfrom
db-show-manifest-version

Conversation

@Diggsey
Copy link
Copy Markdown
Contributor

@Diggsey Diggsey commented Apr 1, 2017

Fixes #1007

I haven't updated the tests yet in case we want to change how it's displayed.

@Diggsey Diggsey requested a review from brson April 1, 2017 17:27
@Diggsey
Copy link
Copy Markdown
Contributor Author

Diggsey commented Apr 1, 2017

Example output:

info: syncing channel updates for 'nightly-x86_64-pc-windows-msvc'
info: latest update on 2015-01-02, rust version 1.3.0
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: downloading component 'cargo'
info: downloading component 'rust-docs'
info: installing component 'rust-std'
info: installing component 'rustc'
info: installing component 'cargo'
info: installing component 'rust-docs'
info: default toolchain set to 'nightly-x86_64-pc-windows-msvc'

@brson
Copy link
Copy Markdown
Contributor

brson commented Apr 5, 2017

Patch looks good to me, but failures are legit. r=me when fixed.

@Diggsey
Copy link
Copy Markdown
Contributor Author

Diggsey commented May 29, 2017

@bors r=brson

@bors
Copy link
Copy Markdown
Contributor

bors commented May 29, 2017

📌 Commit edd013c has been approved by brson

@bors
Copy link
Copy Markdown
Contributor

bors commented May 29, 2017

⌛ Testing commit edd013c with merge ef63df3...

bors added a commit that referenced this pull request May 29, 2017
…rson

Show version of rust being installed

Fixes #1007

I haven't updated the tests yet in case we want to change how it's displayed.
@bors
Copy link
Copy Markdown
Contributor

bors commented May 29, 2017

💔 Test failed - status-appveyor

@Diggsey
Copy link
Copy Markdown
Contributor Author

Diggsey commented May 29, 2017

@bors retry

@bors
Copy link
Copy Markdown
Contributor

bors commented May 29, 2017

⌛ Testing commit edd013c with merge c26a45b...

bors added a commit that referenced this pull request May 29, 2017
…rson

Show version of rust being installed

Fixes #1007

I haven't updated the tests yet in case we want to change how it's displayed.
@bors
Copy link
Copy Markdown
Contributor

bors commented May 29, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing c26a45b to master...

@bors bors merged commit edd013c into master May 29, 2017
@kinnison kinnison deleted the db-show-manifest-version branch April 15, 2019 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants