Skip to content

Better error message when not running in a tty#1026

Merged
bors merged 1 commit intorust-lang:masterfrom
jelford:run_outside_tty
Apr 2, 2017
Merged

Better error message when not running in a tty#1026
bors merged 1 commit intorust-lang:masterfrom
jelford:run_outside_tty

Conversation

@jelford
Copy link
Copy Markdown
Contributor

@jelford jelford commented Apr 1, 2017

-t returns true if the provided file descriptor is open and refers
to a terminal.

jelford@ ~/s/rustup.rs> echo (./rustup-init.sh )
info: downloading installer
rustup: Unable to run interactively. Run with -y to accept defaults, --help for additional options

jelford@ ~/s/rustup.rs> echo (./rustup-init.sh -y)
info: downloading installer
info: updating existing rustup installation

Should close #648

-t returns true if the provided file descriptor is open and refers
to a terminal.
@Diggsey
Copy link
Copy Markdown
Contributor

Diggsey commented Apr 1, 2017

@bors r+

@bors
Copy link
Copy Markdown
Contributor

bors commented Apr 1, 2017

📌 Commit b77c047 has been approved by Diggsey

@bors
Copy link
Copy Markdown
Contributor

bors commented Apr 2, 2017

⌛ Testing commit b77c047 with merge 04597f5...

bors added a commit that referenced this pull request Apr 2, 2017
Better error message when not running in a tty

-t returns true if the provided file descriptor is open and refers
to a terminal.

    jelford@ ~/s/rustup.rs> echo (./rustup-init.sh )
    info: downloading installer
    rustup: Unable to run interactively. Run with -y to accept defaults, --help for additional options

    jelford@ ~/s/rustup.rs> echo (./rustup-init.sh -y)
    info: downloading installer
    info: updating existing rustup installation

Should close #648
@bors
Copy link
Copy Markdown
Contributor

bors commented Apr 2, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: Diggsey
Pushing 04597f5 to master...

@bors bors merged commit b77c047 into rust-lang:master Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

change "/dev/tty does not exist" to something more helpful

3 participants