Fix OpenSSL linkage by using the final install-directory in the build

[jelford]

This PR addresses #1051 by avoiding moving OpenSSL's install-target directory after it's been configured. It also encorporates the regression test suggested by @malbarbo on #1054.

It still makes sense to move directories about to avoid getting a partially-built copy of openssl, and I think it makes sense to cache the finished product rather than the src/build directory.

I haven't been able to test the output on one of the affected platforms (although the check on symbols passes) as I don't know a good way to get artefacts out of the travis build.

[malbarbo]

@jelford I checked the test it it does not print the message when it fails. The script uses set -ex, so if grep fails the script will fail before executing if statement. I you find appropriated, you can update to:

# check that rustup-init was built with ssl support
# see https://github.com/rust-lang-nursery/rustup.rs/issues/1051
if ! (nm target/$TARGET/release/rustup-init | grep Curl_ssl_version &> /dev/null); then
  echo "Missing ssl support!!!!"
  exit 1
fi

[jelford]

Thanks @malbarbo , incorporated your change.

[ghost]

We want this!!!

[Diggsey]

@bors r+
Thanks @jelford and @malbarbo, this looks great.

I can't make a release unfortunately, that'll have to wait until @brson is around.

[bors]

📌 Commit 3b7ada1 has been approved by Diggsey

[bors]

⌛ Testing commit 3b7ada1 with merge eb2896b...

[bors]

💔 Test failed - status-appveyor

[alexreg]

Could we get this merged soon, hopefully? It's quite annoying not to be able to update, right now.

[jelford]

@Diggsey this is going to start to get more urgent with 1.17 shipping. Any timeline on when we might be able to get something pushed out? Sorry to nag.

[Diggsey]

@jelford There's nothing I can do about it unfortunately. @brson is aware of the issue and is going to make a new release ASAP, but he's been away and I imagine has had a ton of stuff to catch up on since getting back.

[jelford]

Okay, thanks for the update, no problem. Sorry for all this.

…

On Fri, 28 Apr 2017, 10:38 Diggory Blake, ***@***.***> wrote: @jelford <https://github.com/jelford> There's nothing I can do about it unfortunately. @brson <https://github.com/brson> is aware of the issue and is going to make a new release ASAP, but he's been away and I imagine has had a ton of stuff to catch up since getting back. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1065 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMhKcEonTTUtJNLHU4NyU1p_Tf_FHIgks5r0bObgaJpZM4M9n2L> .