Add a message when removing a component#1119
Merged
bors merged 1 commit intorust-lang:masterfrom May 18, 2017
Merged
Conversation
Contributor
|
Thanks! It looks like some of the tests need updating? |
Contributor
Author
|
Hmm, do we want to show the removing message when upgrading, or just when actually removing? |
Contributor
|
Just keep it simple for now and always show it. |
matthewjasper
force-pushed
the
removing-message
branch
from
97164eb to
f4b4f44
Compare
matthewjasper
force-pushed
the
removing-message
branch
from
f4b4f44 to
4eeaab3
Compare
Contributor
|
@bors r+ |
Contributor
|
📌 Commit 4eeaab3 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
May 18, 2017
Add a message when removing a component Fixes #306. The message is (for example) ``` info: removing component 'rust-std' for 'x86_64-unknown-linux-musl' ```
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #306.
The message is (for example)