Skip to content

update shebang to reflect bashisms#1269

Merged
Diggsey merged 1 commit intorust-lang:masterfrom
mcandre:patch-1
May 27, 2018
Merged

update shebang to reflect bashisms#1269
Diggsey merged 1 commit intorust-lang:masterfrom
mcandre:patch-1

Conversation

@mcandre
Copy link
Copy Markdown

@mcandre mcandre commented Oct 22, 2017

Update shebang, given that local is not a POSIX semantic. Discovered this when trying to run the rustup installer on Oracle Solaris, where /bin/sh is a symlink to ksh93.

Note that the rustup.rs website should also pipe to bash, not sh.

Alternatively, we can rewrite this script in pure POSIX sh, though I leave that to cooler heads.

Update shebang, given that `local` is not a POSIX semantic.
@mcandre
Copy link
Copy Markdown
Author

mcandre commented Oct 22, 2017

Looks like one of the macOS CI builds stalled for this tweak, dunno why?

https://travis-ci.org/rust-lang-nursery/rustup.rs/jobs/290991285

@mati865
Copy link
Copy Markdown
Member

mati865 commented Oct 29, 2017

If changing to bash using #!/usr/bin/env bash should be preferred.

@mcandre
Copy link
Copy Markdown
Author

mcandre commented Nov 10, 2017

@mati865 Eh, if the shell were ash, dash, or posh, or relied on alpha features from Homebrew bash tip, then /usr/bin/env would definitely help to port the script to varied systems. But for common shell languages like bash, sh, ksh, zsh, the /usr/bin/env prefix just slows things down unnecessarily.

@Diggsey
Copy link
Copy Markdown
Contributor

Diggsey commented May 27, 2018

Thanks for the PR!

@Diggsey Diggsey merged commit 09fb0f5 into rust-lang:master May 27, 2018
@Diggsey Diggsey mentioned this pull request May 27, 2018
AJ-Ianozi pushed a commit to AJ-Ianozi/getada-download that referenced this pull request Oct 12, 2023
update shebang to reflect bashisms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants