Added a link to all installers to the homepage#1370
Added a link to all installers to the homepage#1370Diggsey merged 2 commits intorust-lang:masterfrom t-botz:linkAllInstallers
Conversation
nrc
left a comment
nrc
left a comment
There was a problem hiding this comment.
I think this is a good change, thanks for rebasing the PR. I'd like to fixup the links a little bit though, see comment inline.
www/index.html
Outdated
| <div id="platform-instructions-unix" class="instructions" style="display: none;"> | ||
| <p>Run the following in your terminal, then follow the onscreen instructions.</p> | ||
| <pre>curl https://sh.rustup.rs -sSf | sh</pre> | ||
| <p class="other-platforms-help">You appear to be running Unix. Click <a class="default-platform-button" href="#">here</a> to see the installer for all supported platforms.</p> |
There was a problem hiding this comment.
Could we rephrase these links to avoid the 'click here' anti-pattern, e.g., make the link text "view all supported installers" or something like that
There was a problem hiding this comment.
What about : "You appear to be running Unix. If not, [display all supported installers]."
|
ping @withoutboats any comments on this? |
|
ping @alexcrichton and @withoutboats - any thoughts? I'm inclined to merge this with my review comment addressed. |
|
Sounds good to me! |
|
Hey @thibaultdelor, any chance you could update the PR with that change? Thanks! |
|
Sure will do today
…On Sun., 27 May 2018, 11:04 pm Diggory Blake, ***@***.***> wrote:
Hey @thibaultdelor <https://github.com/thibaultdelor>, any chance you
could update the PR with that change? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1370 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAqWJc6NqAEB6avXFF0s6rt-_qzrk9ajks5t2qRngaJpZM4ShlVT>
.
|
|
Here you go. I have also slightly reduced the font so it looks on one line in windows. It was looking weird otherwise. |
|
r? @Diggsey |
|
Thanks, looks great! |
Added a link to all installers to the homepage
5 participants
re #1253
I have just resolved conflict of #1270 and adapted to the new index page.
Here is how it looks:
