Add --toolchain option to 'rustup doc'#1478
Merged
nrc merged 2 commits intorust-lang:masterfrom Sep 13, 2018
Merged
Conversation
nrc
reviewed
Sep 3, 2018
Member
nrc
left a comment
nrc
left a comment
There was a problem hiding this comment.
This looks good, but could you add a test please?
Contributor
Author
|
@nrc I am not sure where can I add tests for this. I checked but the shorthand is handled by somewhere else so should we even add tests for this? |
Contributor
Author
|
Added tests with simple check to test if toolchain is working with nightly. |
Member
|
Great, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1477