rustup-dist: Use Download notifications to track install#1593
rustup-dist: Use Download notifications to track install#1593nrc merged 2 commits intorust-lang:masterfrom
Conversation
ef14a81 to
77cbe9f
Compare
|
All the rebase does is remove one of the fixes messages because it was over-enthusiastic. |
33d6a8c to
771c120
Compare
nrc
left a comment
There was a problem hiding this comment.
Thanks for the PR, I think this is probably a good idea. I would move the reader from the manifestation module to somewhere else though, maybe the dist::download module or a utils module somewhere
|
I will look at the right place to move it to, and attempt to get to it later when I'm home for the evening. I worry that the callback nesting might take me a while to get right though, so it might be a day or two before I can post depending on how awake I am when I get home. Thanks for the confirmation that the idea itself is okay though. |
771c120 to
66336e5
Compare
|
@nrc turns out that the FileReaderWithProgress moved nicely to |
|
Interestingly there's some formatting differences in the CI. I'll have to double-check my rustfmt install. |
66336e5 to
c8d7c8e
Compare
|
I've rebased and hopefully that'll clear up that formatting issue. |
In order to be able to report unpack progress, add support for a file reader which emits notifications akin to the downloading of a file. This allows the generic progress bar supporting downloads to also handle the installation of components. Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
People have requested some indication of progress for long-running install steps. This commit uses the new FileReaderWithProgress to provide a progress bar (the length is the compressed component tarball but should be good enough) to provide such feedback. Fixes: rust-lang#1557 Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
c8d7c8e to
aaead82
Compare
|
Thanks! |
People have requested some indication of progress for long-running
install steps. This commit re-uses the download tracker logic to
provide a progress bar (the length is the compressed component
tarball but should be good enough) to provide such feedback.
Fixes: #1557