When updating, show "removing old component" to avoid confusion#1639
Merged
nrc merged 1 commit intorust-lang:masterfrom Feb 11, 2019
Merged
When updating, show "removing old component" to avoid confusion#1639nrc merged 1 commit intorust-lang:masterfrom
nrc merged 1 commit intorust-lang:masterfrom
Conversation
kinnison
approved these changes
Feb 5, 2019
Contributor
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
I like this idea, it's neat and clean. 👍
Member
|
nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolution for UX issue described by #1283
When components were uninstalled during an update previously, the message would be:
This has been changed to reassure the user that only old versions are being uninstalled: