Skip to content

Add some debugging utilities to rustup-mock#1677

Merged
kinnison merged 2 commits intorust-lang:masterfrom
dwijnand:rustup-mock-tweaks
Mar 4, 2019
Merged

Add some debugging utilities to rustup-mock#1677
kinnison merged 2 commits intorust-lang:masterfrom
dwijnand:rustup-mock-tweaks

Conversation

@dwijnand
Copy link
Copy Markdown
Contributor

@dwijnand dwijnand commented Mar 2, 2019

No description provided.

dwijnand added 2 commits March 2, 2019 10:39
I think this is useful to help understand how two multi-line strings are different.
@dwijnand dwijnand force-pushed the rustup-mock-tweaks branch from 2d1d7f9 to 1ba104c Compare March 2, 2019 11:48
Copy link
Copy Markdown
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that you encountered something which led you to want these extra bits of debug.

I have nothing against them being in.

@dwijnand
Copy link
Copy Markdown
Contributor Author

dwijnand commented Mar 3, 2019

Yeah I built these while reviewing #1655, but decided to push them separately rather than tagged on there.

@kinnison
Copy link
Copy Markdown
Contributor

kinnison commented Mar 4, 2019

Cool, I don't see any danger in including them.

@kinnison kinnison merged commit 297b177 into rust-lang:master Mar 4, 2019
@dwijnand dwijnand deleted the rustup-mock-tweaks branch March 4, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants