update reqwest to 0.9.14, enable socks feature#1746
Merged
kinnison merged 1 commit intorust-lang:masterfrom Apr 10, 2019
Merged
update reqwest to 0.9.14, enable socks feature#1746kinnison merged 1 commit intorust-lang:masterfrom
kinnison merged 1 commit intorust-lang:masterfrom
Conversation
kinnison
approved these changes
Apr 10, 2019
Contributor
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
Since this includes a Cargo.lock change, I'll want to review it more carefully when I have access to my personal laptop, but on the face of it, the change to Cargo.toml looks fine.
Amusingly I was gearing up to ping you this morning about these very issues to see how the reqwest work was going, so this is an awesome thing to wake up to. Thank you.
(Approval is subject to my checking Cargo.lock later today)
Contributor
|
I have confirmed the Cargo.lock update is good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1712
Fixes #1736
(It'd be cool if we had some proxy tests so that we could add some more, but we don't...)