Correctly document rustup defaults on Windows#1753
Merged
nrc merged 1 commit intorust-lang:masterfrom Apr 15, 2019
Merged
Conversation
kinnison
reviewed
Apr 11, 2019
Contributor
Author
|
Please feel free to edit the pr to suit. I changed this to change the
target abi rather than arch because I suspect it's more common, and still
demonstrates setting one of the for options listed immediately below.
…On Thu, 11 Apr 2019, 22:14 Daniel Silverstone, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#1753 (comment)>:
>
```console
-$ rustup set default-host x86_64-pc-windows-msvc
+$ rustup set default-host x86_64-pc-windows-gnu
I *think* this bit was meant to be demonstrating the change in i686 vs.
x86_64 rather than msvc vs gnu which I think is addressed elsewhere in
the README.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1753 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAef3pVEII7_KTnWrX82IesgTm2wsnlZks5vfwsegaJpZM4cpPBk>
.
|
rustup checks the host OS for the CPU arch
kinnison
approved these changes
Apr 14, 2019
Contributor
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
I've tweaked the wording and think this is good to merge now
Member
|
Thanks both! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustup checks the host OS for the CPU arch