Fix clippy warnings and errors#1778
Merged
kinnison merged 17 commits intorust-lang:masterfrom Apr 22, 2019
Merged
Conversation
kinnison
reviewed
Apr 21, 2019
Contributor
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
Apart from my one (probably irrelevant) concern about lock semantics in the mutex->atomicbool change, I'm happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clippy log here: https://travis-ci.com/lzutao/rustup.rs/jobs/194219923#L573
Note: I categorized each kind of clippy warnings to each commit. So it would be
easier to review if you read commit one-by-one rather than read it all
in
File changedtab.