Fix displaying ETA output for download tracker, make it consistent & treat output as integers.#1832
Conversation
|
I thought we'd already dealt with this, sigh. What types are involved here because really all of the days/hours/minutes/seconds should be integers. |
|
@rbtcollins Could you take a look and ensure that your PRs would fix this too? Assuming so, let me know and we'll close this in favour of the more deep correction. If not, then if I merge this, could you update your PRs to match? |
|
☔ The latest upstream changes (presumably #1836) made this pull request unmergeable. Please resolve the merge conflicts. |
|
My PR didn't fix this sorry, I was fixing an orthogonal problem - this change is still needed; @konstankinollc could you please rebase your patch then @kinnison can merge it? Thanks! |
|
Absolutely, will do in a bit. |
|
@kinnison ready for your review |
konstankinollc
changed the title
|
It also addresses a bug in computing hours to download. |
|
Can anyone please explain why the build is failing on CI? |
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
As noted, please don't update the package version in Cargo.toml and I've explained the CI failure for you
konstankinollc
force-pushed
the
master
branch
2 times, most recently
from
9c45e86 to
58408ea
Compare
Make download duration output consistent & treat as integers.
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
LGTM now, if it passes CI then it can merge IMO
konstankinollc
changed the title
4 participants
Addresses #1831