Don't set mtime on toolchain files#1847
Merged
kinnison merged 1 commit intorust-lang:masterfrom May 11, 2019
Merged
Conversation
We don't depend on file times in the toolchains for any of our operations, so making them match the time from the tar archive isn't particularly useful. My bench machine here dropped from 31/32s for rust-docs to 26/27s with this change.
kinnison
approved these changes
May 11, 2019
Contributor
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
I've had a rummage and I'm fairly sure this is safe, and the speedup on Windows is impressive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't depend on file times in the toolchains for any of our
operations, so making them match the time from the tar archive isn't
particularly useful. My bench machine here dropped from 31/32s for
rust-docs to 26/27s with this change.