feat: --quiet option

[PicoJr]

PR Content

issue: #1928

add --quiet option. it disables progress console output.

TODO

• write unit test for this new option.
• verify default behavior in proxy_mode.rs is the right one.

[kinnison]

is this a reasonable default?

I'll need to properly review to be sure, but first glance suggests it's okay.

I don't really understand the purpose of proxy_mode.rs

This is the entry point for rustup proxies. Proxying is the mechanism by which rustc cargo etc, are really rustup but we use argv[0] to decide which command to run from inside the detected toolchain. It can result in a download if the detected toolchain isn't installed I think, though in that context, I imagine defaulting to quiet is fine.

[kinnison]

After reviewing, I'm mildly concerned that we have verbose and quiet which are not really antonyms of one another. But I'm also not sure of better terminology right now.

I'll await your further updates with tests etc, before I pass judgement further. Renaming options is the easiest of things to do.

Could you also be sure to rebase against new master since I've merged a change which might make the CI more useful.

[PicoJr]

After reviewing, I'm mildly concerned that we have verbose and quiet which are not really antonyms of one another. But I'm also not sure of better terminology right now.

I'll await your further updates with tests etc, before I pass judgement further. Renaming options is the easiest of things to do.

Could you also be sure to rebase against new master since I've merged a change which might make the CI more useful.

Ok, thanks for the review =), I'll rebase and update the PR accordingly.

• rebase
• add unit tests

[PicoJr]

Tests

The goal of --quiet is to suppress progress output.

During unit tests stdout and stderr are checked against expected output.

However final stdout is the same regardless of whether or not --quiet option was used (progress line is flushed out).

For the lack of a better solution I copied tests from cli-rustup.rs: rustup_stable and toolchain_install_is_like_update and used --quiet option.

It won't prove the feature works as expected (disables the progress output) but it shows the --quiet option can be used and produces the same output as before (except for the progress line)

I'm open to suggestions for improving the tests

Name

As for the option name, wget has a --progress=type option.

--quiet could be renamed as --no-progress ?

[bors]

☔ The latest upstream changes (presumably ec6d1af) made this pull request unmergeable. Please resolve the merge conflicts.

[kinnison]

Just a query about verbose vs quiet then probably mergeable

[kinnison]

LGTM, Thank you 👍