Skip to content

Fix/improve human-readable units#2043

Merged
kinnison merged 1 commit intorust-lang:masterfrom
Rudi3:fix_size_units
Nov 11, 2019
Merged

Fix/improve human-readable units#2043
kinnison merged 1 commit intorust-lang:masterfrom
Rudi3:fix_size_units

Conversation

@Rudi3
Copy link
Copy Markdown
Contributor

@Rudi3 Rudi3 commented Oct 7, 2019

Attempt to fix #2041.

Differentiates between B|B/s and IO-ops|IOPS and formats them human-friendly.

@Rudi3 Rudi3 force-pushed the fix_size_units branch 7 times, most recently from 8406bed to 559895b Compare October 7, 2019 23:31
@Rudi3 Rudi3 changed the title Fix/improve human-readable units [don't merge] Fix/improve human-readable units Oct 7, 2019
@Rudi3 Rudi3 changed the title [don't merge] Fix/improve human-readable units [do not merge] Fix/improve human-readable units Oct 8, 2019
@Rudi3 Rudi3 changed the title [do not merge] Fix/improve human-readable units Fix/improve human-readable units Oct 8, 2019
@kinnison
Copy link
Copy Markdown
Contributor

kinnison commented Oct 8, 2019

Since this touches code @rbtcollins wrote, I'd like their opinion on it.

@kinnison kinnison requested a review from rbtcollins October 8, 2019 11:32
@kinnison kinnison added this to the 1.21.0 milestone Nov 10, 2019
@kinnison kinnison merged commit 017d981 into rust-lang:master Nov 11, 2019
@Rudi3 Rudi3 deleted the fix_size_units branch November 11, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

N iops / N iops (100%) M iops/s makes no sense

2 participants