component: Support installation/removal of component-target#2088
Merged
kinnison merged 2 commits intorust-lang:masterfrom Oct 29, 2019
Merged
component: Support installation/removal of component-target#2088kinnison merged 2 commits intorust-lang:masterfrom
component-target#2088kinnison merged 2 commits intorust-lang:masterfrom
Conversation
Contributor
Author
|
WHile this isn't ready yet (no tests) I'd appreciate a quick nod from @shepmaster if this is appropriate. |
Contributor
Author
|
I think those tests are sufficient. |
shepmaster
approved these changes
Oct 29, 2019
Member
shepmaster
left a comment
shepmaster
left a comment
There was a problem hiding this comment.
The functionality all seems reasonable to me! Just minor comments since I read the code anyway.
In order to reduce the surprise available when someone expects to be able to take output of `rustup component list` and use it as input to `rustup component add` or `rustup component remove` we now support creation of `Component` objects by attempting to split it on '-' and see if we get a component name and valid full target triple. Fixes: rust-lang#2057
kinnison
force-pushed
the
kinnison/component-with-target
branch
from
4a05a5e to
72f9880
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to reduce the surprise available when someone expects to be able to
take output of
rustup component listand use it as input torustup component addorrustup component removewe now support creation ofComponentobjects by attempting to split it on '-' and see if we get a component name and
valid full target triple.
Fixes: #2057