Make target="*" components detectable if ascribed a target.#2115
Merged
kinnison merged 1 commit intorust-lang:masterfrom Nov 11, 2019
Merged
Make target="*" components detectable if ascribed a target.#2115kinnison merged 1 commit intorust-lang:masterfrom
kinnison merged 1 commit intorust-lang:masterfrom
Conversation
In order to mitigate an issue from Profile support where rust-src would be ascribed a target during installation under the `complete` profile, make the component-in-components check a little more robust. In theory we can remove this when we're confident that future users won't have broken installs left behind. Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to mitigate an issue from Profile support where rust-src
would be ascribed a target during installation under the
completeprofile, make the component-in-components check a little more robust.
In theory we can remove this when we're confident that future users
won't have broken installs left behind.
This ought to fix #2113