Skip to content

Update links#2173

Merged
kinnison merged 3 commits intorust-lang:masterfrom
JohnTitor:update-links
Dec 29, 2019
Merged

Update links#2173
kinnison merged 3 commits intorust-lang:masterfrom
JohnTitor:update-links

Conversation

@JohnTitor
Copy link
Copy Markdown
Member

Also,

documentation = "https://rust-lang.github.io/rustup.rs/rustup/index.html"

should be replaced but I'm not sure what the correct link is (https://rustup.rs?).

@kinnison
Copy link
Copy Markdown
Contributor

We don't really have rustdoc published any more for rustup because it's not a library for others to use. I'd suggest we either replace it with https://rustup.rs/ or just drop the documentation entry alltogether.

@JohnTitor
Copy link
Copy Markdown
Member Author

I feel it's meaningless nowadays so I dropped it. (offtopic: I saw your message on Discord, no rush, take care of yourself!)

Copy link
Copy Markdown
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these look good to me, Thank you!

@kinnison kinnison merged commit d6366cb into rust-lang:master Dec 29, 2019
@JohnTitor JohnTitor deleted the update-links branch December 29, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants