Skip to content

www: show whole shell command at once#2208

Merged
kinnison merged 1 commit intorust-lang:masterfrom
harrysarson:show-shell
Jan 25, 2020
Merged

www: show whole shell command at once#2208
kinnison merged 1 commit intorust-lang:masterfrom
harrysarson:show-shell

Conversation

@harrysarson
Copy link
Copy Markdown
Contributor

@harrysarson harrysarson commented Jan 21, 2020

Makes the width of the shell box slightly larger and the font size slightly smaler.

Fixes: #2207

Before:
image

After:
image


cc: @birkenfeld

@birkenfeld
Copy link
Copy Markdown

For me, looks like this:

image

So a bit more generous, and we're good :)

Copy link
Copy Markdown
Contributor Author

@harrysarson harrysarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it look now?

Makes the width of the shell box slightly larger and the font size slightly smaler.

Fixes: rust-lang#2207
@harrysarson
Copy link
Copy Markdown
Contributor Author

@brikenfeld have you had a chance to have a look?

@birkenfeld
Copy link
Copy Markdown

LGTM now, thanks!

Copy link
Copy Markdown
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason not to accept this. Website updates happen on releases of rustup normally so you won't see any updates until the release of 1.22.0 but then it should be done. Thank you all for your efforts cleaning this up.

@kinnison kinnison merged commit dd8dbf3 into rust-lang:master Jan 25, 2020
@harrysarson harrysarson deleted the show-shell branch January 25, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Website: show whole shell command at once

3 participants