Let docs pass through with custom toolchains#2235
Merged
rbtcollins merged 1 commit intorust-lang:masterfrom Feb 24, 2020
Merged
Let docs pass through with custom toolchains#2235rbtcollins merged 1 commit intorust-lang:masterfrom
rbtcollins merged 1 commit intorust-lang:masterfrom
Conversation
Following rust-lang#2116, custom toolchains started to fail `rustup doc`, since they can't list components to check if `rust-docs` is installed. error: toolchain 'system' does not support components error: caused by: invalid toolchain name: 'system' Now custom toolchains just skip that component check, and it's up to the user to have installed the documentation in their own way.
Contributor
|
I think this raises a point about our API: custom toolchains shouldn't let us list try to list components - that code should have forced a compile error in the first place to help us understand that this problem would have arisen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #2116, custom toolchains started to fail
rustup doc, sincethey can't list components to check if
rust-docsis installed.Now custom toolchains just skip that component check, and it's up to the
user to have installed the documentation in their own way.