notifications: list all missing components when skipping nightlies#2316
Merged
kinnison merged 1 commit intorust-lang:masterfrom May 8, 2020
Merged
Conversation
Currently when updating and skipping nightlies due to missing required components only one such missing component is shown. Users might consider removing the requirement for the component and updating to the specific nightly that was missing it, only to find out that there is another, newly discovered missing component. With this change all required and missing components are shown when a nightly is skipped, so users might be able to quickly identify which nightly version, if any, has an acceptable set of missing components. Signed-off-by: Alejandro Martinez Ruiz <amr@redhat.com>
unleashed
force-pushed
the
show-nightlies-missing-components
branch
from
16d62c3 to
6a5951b
Compare
kinnison
approved these changes
May 8, 2020
Contributor
|
Thank you for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when updating and skipping nightlies due to missing required components only one such missing component is shown. Users might consider removing the requirement for the component and updating to the specific nightly that was missing it, only to find out that there is another, newly discovered missing component.
With this change all required and missing components are shown when a nightly is skipped, so users might be able to quickly identify which nightly version, if any, has an acceptable set of missing components.