Skip to content

Adds Rust favicon#2419

Merged
kinnison merged 1 commit intorust-lang:masterfrom
sl4m:update-favicon
Jan 13, 2021
Merged

Adds Rust favicon#2419
kinnison merged 1 commit intorust-lang:masterfrom
sl4m:update-favicon

Conversation

@sl4m
Copy link
Copy Markdown

@sl4m sl4m commented Jul 15, 2020

Adds favicons to minimally support Chrome, Firefox, and Safari browsers.

@sl4m sl4m force-pushed the update-favicon branch from 5a1357a to ece50ac Compare July 15, 2020 17:38
@kinnison
Copy link
Copy Markdown
Contributor

Where did these image files come from?

@sl4m
Copy link
Copy Markdown
Author

sl4m commented Jul 16, 2020

Where did these image files come from?

From https://github.com/rust-lang/www.rust-lang.org

@kinnison
Copy link
Copy Markdown
Contributor

Assuming we're allowed to cross-link with the relevant content policies etc, it may make more sense to just reference them from www.rust-lang.org then, rather than copying them over.

@sl4m sl4m force-pushed the update-favicon branch from ece50ac to aefe72d Compare July 16, 2020 19:59
@sl4m
Copy link
Copy Markdown
Author

sl4m commented Jul 16, 2020

I've updated index.html to just reference assets from www.rust-lang.org

@kinnison
Copy link
Copy Markdown
Contributor

@pietroalbini What would it take to deploy this to dev- so that we can verify the favicons work like this?

@emilyalbini
Copy link
Copy Markdown
Member

@kinnison we need to do the dev promotion of a release.

@kinnison
Copy link
Copy Markdown
Contributor

hmm, not the easiest thing to do with a prospective change then

Copy link
Copy Markdown

@4ldas 4ldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. However could add metatags for favicons and stuff too

@kinnison
Copy link
Copy Markdown
Contributor

I'm sorry it has taken so long to come back to this. At worst if this doesn't work then it simply won't work, right? Or will it cause browsers to complain to users?

@emilyalbini
Copy link
Copy Markdown
Member

If this does not work I don't think users will see an explicit error from browsers. Still, we should try this out before doing the prod promotion.

@kinnison
Copy link
Copy Markdown
Contributor

Okay, I'll merge this and we should remember to check it during the 1.24 release process

@kinnison kinnison merged commit 4771dbf into rust-lang:master Jan 13, 2021
@sl4m sl4m deleted the update-favicon branch January 13, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants