Conversation
|
Where did these image files come from? |
From https://github.com/rust-lang/www.rust-lang.org |
|
Assuming we're allowed to cross-link with the relevant content policies etc, it may make more sense to just reference them from www.rust-lang.org then, rather than copying them over. |
|
I've updated |
|
@pietroalbini What would it take to deploy this to dev- so that we can verify the favicons work like this? |
|
@kinnison we need to do the dev promotion of a release. |
|
hmm, not the easiest thing to do with a prospective change then |
|
I'm sorry it has taken so long to come back to this. At worst if this doesn't work then it simply won't work, right? Or will it cause browsers to complain to users? |
|
If this does not work I don't think users will see an explicit error from browsers. Still, we should try this out before doing the prod promotion. |
|
Okay, I'll merge this and we should remember to check it during the 1.24 release process |
Adds favicons to minimally support Chrome, Firefox, and Safari browsers.