Add socks5 support for reqwest-backend#2466
Merged
kinnison merged 3 commits intorust-lang:masterfrom Sep 3, 2020
eidenar:reqwest-backend-socks-support
Merged
Add socks5 support for reqwest-backend#2466kinnison merged 3 commits intorust-lang:masterfrom eidenar:reqwest-backend-socks-support
kinnison merged 3 commits intorust-lang:masterfrom
eidenar:reqwest-backend-socks-support
Conversation
Contributor
|
I wonder if there's any way we can add a test to ensure that we don't accidentally lose this capability? |
Author
|
@kinnison I added a test to check if socks5 feature is enabled. It performs a simple request with non-existent socks5 address from |
kinnison
reviewed
Aug 24, 2020
Contributor
|
I've rebased this (as |
In order to ensure that we do not stomp on each other when running tests in the download crate to verify proxy behaviour, introduce a Mutex to guard against this. Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
Author
|
I've updated commits and messages to be clear, @kinnison. |
kinnison
approved these changes
Sep 3, 2020
Contributor
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
This looks good to me, thank you for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #2409, rustup doesn't use socks5 proxy with reqwest backend. It turned out, that enabling socks feature in Cargo.toml is enough to make it work as intended.
There was no updates from the last person worked on this issue for almost a month, so I decided to pick it up.