Give a better error message when a component isn't installed for a custom toolchain#2487
Merged
kinnison merged 1 commit intorust-lang:masterfrom Sep 16, 2020
Merged
Conversation
7f15622 to
2a6b4c9
Compare
Contributor
|
Personally I do I think |
kinnison
suggested changes
Sep 15, 2020
Contributor
kinnison
left a comment
There was a problem hiding this comment.
This is pretty close to spot on. I'll even forgive the x.py providing you tweak the wording a bit.
82447b9 to
3684347
Compare
kinnison
suggested changes
Sep 15, 2020
Contributor
kinnison
left a comment
There was a problem hiding this comment.
Looks good, please rebase to remove the response commit now I've checked it.
…stom toolchain This re-orders imports because rustfmt really wants them to change.
3684347 to
39c23c5
Compare
Member
Author
|
Rebased :) |
kinnison
approved these changes
Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2470.
I did the thing you told me not to do which is mention x.py :P let me know if I should remove it.
I'm not sure how to run a custom rustup without installing it on top of my existing install ...
cargo rungives meIs there a way to test this by hand or do you only have unit tests? I want to see what the output looks like.