UX: Report non-installable toolchains#2562
Merged
kinnison merged 2 commits intorust-lang:masterfrom Feb 20, 2021
Merged
Conversation
Contributor
Author
|
Hmm, I really need to write the tests for this so that I can finish it out. |
kinnison
force-pushed
the
fix-failed-install-2547
branch
2 times, most recently
from
b4228c4 to
8faa028
Compare
If you pick a default toolchain which is not installable, or if you try to `rustup toolchain install` something non-installable then we should report it as such and exit non-zero so scripting can fail. Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
kinnison
force-pushed
the
fix-failed-install-2547
branch
from
8faa028 to
1c1c03a
Compare
kinnison
commented
Jan 15, 2021
Contributor
Author
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
I am now satisfied with this patch, assuming green CI I'll un-draft the PR
Contributor
Author
|
@jyn514 Are you able to check if this would solve your particular problem? I can only try on Linux by default. |
Member
|
Worked like a charm! Thanks for the fix! |
jyn514
reviewed
Jan 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you pick a default toolchain which is not installable, or if you
try to
rustup toolchain installsomething non-installable then weshould report it as such and exit non-zero so scripting can fail.
This fixes #2547
Starting this as draft because this needs tests but I'm feeling too tired to write some for now.