Skip to content

show active-toolchain with rustc info#2710

Merged
kinnison merged 4 commits intorust-lang:masterfrom
0xPoe:rustin-patch-show
Apr 29, 2021
Merged

show active-toolchain with rustc info#2710
kinnison merged 4 commits intorust-lang:masterfrom
0xPoe:rustin-patch-show

Conversation

@0xPoe
Copy link
Copy Markdown
Member

@0xPoe 0xPoe commented Apr 5, 2021

close #2685

@0xPoe 0xPoe changed the title how active-toolchain with rustc info show active-toolchain with rustc info Apr 5, 2021
@0xPoe 0xPoe force-pushed the rustin-patch-show branch 2 times, most recently from ee9645f to c400594 Compare April 5, 2021 09:52
@0xPoe

This comment has been minimized.

@0xPoe

This comment has been minimized.

@kinnison
Copy link
Copy Markdown
Contributor

Could you please add a comment here showing what a full output of rustup show displays (before/after your PR if it has changed) and what rustup show --verbose shows?

I'm not entirely sure it's worth adding --verbose rather than just always showing the information so I'd like to see.

@0xPoe
Copy link
Copy Markdown
Member Author

0xPoe commented Apr 13, 2021

Without my change:

stable-x86_64-apple-darwin (default)

with my change but without verbose:

➜  rustup git:(rustin-patch-show) ./home/bin/rustup  show active-toolchain                                     
stable-x86_64-apple-darwin (default)
➜  rustup git:(rustin-patch-show) 

with my change and verbose:

➜  rustup git:(rustin-patch-show) ./home/bin/rustup  show active-toolchain --verbose
stable-x86_64-apple-darwin (default) - rustc 1.51.0 (2fd73fabe 2021-03-23)
➜  rustup git:(rustin-patch-show) 

@0xPoe
Copy link
Copy Markdown
Member Author

0xPoe commented Apr 16, 2021

@kinnison ping~

@rbtcollins
Copy link
Copy Markdown
Contributor

rbtcollins commented Apr 21, 2021

I think showing it in the same format that rustup show does would be better: one per line. Concretely this is better for folk using sed to query etc.

@0xPoe 0xPoe force-pushed the rustin-patch-show branch from 61093b5 to e96897b Compare April 22, 2021 02:45
Better format
@0xPoe 0xPoe force-pushed the rustin-patch-show branch from e96897b to 7909352 Compare April 22, 2021 02:49
@0xPoe
Copy link
Copy Markdown
Member Author

0xPoe commented Apr 22, 2021

I think showing it in the same format that rustup show does would be better: one per line. Concretely this is better for folk using sed to query etc.

Fixed.

@kinnison kinnison merged commit d6db55d into rust-lang:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustup show active-toolchain could be more detailed

3 participants