Fixes #2748 by filling the streaming buffers fully#2750
Merged
kinnison merged 2 commits intorust-lang:masterfrom May 4, 2021
Merged
Fixes #2748 by filling the streaming buffers fully#2750kinnison merged 2 commits intorust-lang:masterfrom
kinnison merged 2 commits intorust-lang:masterfrom
Conversation
rbtcollins
force-pushed
the
fillthebuffers
branch
2 times, most recently
from
79bf799 to
094e497
Compare
Diagnosis by Daniel. Code by Robert.
kinnison
reviewed
May 4, 2021
Contributor
|
If we're making this change can we also add |
Contributor
Author
Sure. Though as discussed, don't think its material. |
Contributor
It dropped the max-rss by not-quite-a-chunk in my basic testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnosis by Daniel. Code by Robert.