Support set auto-self-update mode by 0xPoe · Pull Request #2763 · rust-lang/rustup

0xPoe · 2021-05-10T06:23:08Z

The PR supports three different modes of auto self update: enable/disable/check-only.

When enabled, commands such as install or update will update rustup itself.
When disable, commands such as install or update will not update rustup itself. Only self udpate will update rustup itself.
When check-only, commands such as install or update will not update rustup itself but will check for updates. Only self udpate will update rustup itself.

This PR removes a large number of "--no-self-update" args in tests(setup will turn off auto self update by default.)
Add tests for check-only and enable.
add docs

src/cli/rustup_mode.rs

kinnison

There are a number of whitespace changes in this PR. I don't mind them too much, but in future it's best if this kind of reformatting is only done in independent commits/PRs.

I have made a number of wording change suggestions. You do not have to accept them all, but in general I think they're likely to improve matters.

doc/src/basics.md

src/cli/rustup_mode.rs

src/config.rs

src/notifications.rs

0xPoe · 2021-05-12T11:22:59Z

There are a number of whitespace changes in this PR. I don't mind them too much, but in future it's best if this kind of reformatting is only done in independent commits/PRs.

Got it.

0xPoe · 2021-05-16T10:36:44Z

@kinnison Could you please take another look? All comments addressed. Thanks!

0xPoe · 2021-05-19T01:00:20Z

Conflicts have been resolved.

kinnison

A couple of doc tweaks and a question which might be "no need" or might lead to a slight code change - otherwise I think this is nearly ready to merge.

doc/src/basics.md

src/cli/rustup_mode.rs

0xPoe · 2021-05-23T10:40:52Z

Commits squashed.

doc/src/basics.md

kinnison

Assuming CI goes green, I think this is okay. @rbtcollins ?

doc/src/basics.md

src/cli/rustup_mode.rs

src/settings.rs

src/cli/self_update.rs

src/cli/rustup_mode.rs

src/settings.rs

rbtcollins

looking quite good

doc/src/basics.md

src/cli/rustup_mode.rs

src/cli/self_update.rs

src/settings.rs

0xPoe · 2021-05-25T13:19:46Z

@rbtcollins All comments addressed. Thanks for your review!

0xPoe · 2021-05-26T14:57:08Z

@rbtcollins @kinnison Can we merge it? Are there any other issues?

kinnison

One tiny suggestion, otherwise I'm good with this. If @rbtcollins is happy then we can merge IMO.

src/cli/rustup_mode.rs

0xPoe · 2021-05-27T13:40:21Z

It seems the docker image is broken.

rbtcollins

Minor nits - I'll fix these I think

rbtcollins · 2021-05-27T18:49:00Z

doc/src/basics.md

-Running `rustup update` also checks for updates to `rustup` itself and automatically
-installs the latest version. To manually update `rustup` only,
-without updating installed toolchains, type `rustup self update`:
+If your `rustup` was build with the `no-self-update` feature, it will not be able to update itself.


should be past tense

'was built with'

rbtcollins · 2021-05-27T18:52:16Z

src/cli/rustup_mode.rs

+        let arg0 = arg0
+            .as_ref()
+            .and_then(|a| a.to_str())
+            .ok_or(CLIError::NoExeFilePath)?;


We already have NoExeName : I don't think is different enough to bother with a new error (and as the error is never caught and never repeated, we can just use anyhow!(...)

test: clean up "--no-self-update" args test: add check-only and enable tests docs: update docs and add comment

0xPoe · 2021-05-28T01:25:49Z

@rbtcollins @kinnison Thanks again for your review!

0xPoe marked this pull request as draft May 10, 2021 06:24

This comment has been minimized.

Sign in to view

0xPoe force-pushed the rustin-patch-slef-update branch 2 times, most recently from ae19fc2 to f46b487 Compare May 12, 2021 07:50

0xPoe marked this pull request as ready for review May 12, 2021 07:51

0xPoe changed the title ~~Support self-update modes~~ Support set auto-self-update modes May 12, 2021

0xPoe changed the title ~~Support set auto-self-update modes~~ Support set auto-self-update mode May 12, 2021

0xPoe force-pushed the rustin-patch-slef-update branch from d970923 to 945b625 Compare May 12, 2021 08:30

rbtcollins reviewed May 12, 2021

View reviewed changes

src/cli/rustup_mode.rs Outdated Show resolved Hide resolved

rbtcollins reviewed May 12, 2021

View reviewed changes

src/cli/rustup_mode.rs Outdated Show resolved Hide resolved

0xPoe force-pushed the rustin-patch-slef-update branch from 13a4df1 to 9413cb6 Compare May 12, 2021 10:06

kinnison suggested changes May 12, 2021

View reviewed changes

0xPoe force-pushed the rustin-patch-slef-update branch from e075b80 to d235ade Compare May 12, 2021 11:14

0xPoe requested review from kinnison and rbtcollins May 12, 2021 11:21

0xPoe force-pushed the rustin-patch-slef-update branch from d235ade to ec192fe Compare May 12, 2021 11:59

0xPoe force-pushed the rustin-patch-slef-update branch from ec192fe to fddbc2e Compare May 19, 2021 00:58

kinnison suggested changes May 23, 2021

View reviewed changes

doc/src/basics.md Outdated Show resolved Hide resolved

doc/src/basics.md Outdated Show resolved Hide resolved

src/cli/rustup_mode.rs Show resolved Hide resolved

0xPoe force-pushed the rustin-patch-slef-update branch from 338f0bd to 390acde Compare May 23, 2021 10:00

0xPoe requested a review from kinnison May 23, 2021 10:02

0xPoe force-pushed the rustin-patch-slef-update branch from 390acde to 11c1d3b Compare May 23, 2021 10:40

kinnison suggested changes May 23, 2021

View reviewed changes

doc/src/basics.md Outdated Show resolved Hide resolved

0xPoe force-pushed the rustin-patch-slef-update branch from 11c1d3b to 3670450 Compare May 23, 2021 11:41

kinnison approved these changes May 23, 2021

View reviewed changes

rbtcollins reviewed May 23, 2021

View reviewed changes

doc/src/basics.md Outdated Show resolved Hide resolved

doc/src/basics.md Outdated Show resolved Hide resolved

src/cli/rustup_mode.rs Show resolved Hide resolved

src/settings.rs Outdated Show resolved Hide resolved

src/cli/self_update.rs Show resolved Hide resolved

0xPoe requested a review from rbtcollins May 24, 2021 00:58

0xPoe requested a review from kinnison May 24, 2021 00:58

0xPoe force-pushed the rustin-patch-slef-update branch 2 times, most recently from 6f481f2 to a558f65 Compare May 24, 2021 01:10

rbtcollins suggested changes May 25, 2021

View reviewed changes

src/cli/self_update.rs Show resolved Hide resolved

src/cli/rustup_mode.rs Outdated Show resolved Hide resolved

src/settings.rs Outdated Show resolved Hide resolved

0xPoe force-pushed the rustin-patch-slef-update branch 2 times, most recently from d5b8ed7 to 2c7134f Compare May 25, 2021 07:33

0xPoe requested a review from rbtcollins May 25, 2021 07:34

0xPoe marked this pull request as draft May 25, 2021 07:52

0xPoe force-pushed the rustin-patch-slef-update branch 2 times, most recently from 80f9e55 to 31fd3c6 Compare May 25, 2021 08:15

0xPoe marked this pull request as ready for review May 25, 2021 08:16

rbtcollins reviewed May 25, 2021

View reviewed changes

0xPoe force-pushed the rustin-patch-slef-update branch from 6b46b3d to 8797fa8 Compare May 25, 2021 13:18

0xPoe requested a review from rbtcollins May 25, 2021 13:19

0xPoe force-pushed the rustin-patch-slef-update branch from 8797fa8 to 9539557 Compare May 25, 2021 13:41

kinnison approved these changes May 27, 2021

View reviewed changes

src/cli/rustup_mode.rs Outdated Show resolved Hide resolved

0xPoe force-pushed the rustin-patch-slef-update branch 2 times, most recently from b74cfea to d85d0be Compare May 27, 2021 13:36

rbtcollins reviewed May 27, 2021

View reviewed changes

Support self-update modes

3670473

test: clean up "--no-self-update" args test: add check-only and enable tests docs: update docs and add comment

rbtcollins force-pushed the rustin-patch-slef-update branch from d85d0be to 3670473 Compare May 27, 2021 19:39

rbtcollins merged commit 494b307 into rust-lang:master May 27, 2021

0xPoe deleted the rustin-patch-slef-update branch May 27, 2021 23:30

Conversation

0xPoe commented May 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

kinnison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xPoe commented May 12, 2021

Uh oh!

0xPoe commented May 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xPoe commented May 19, 2021

Uh oh!

kinnison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xPoe commented May 23, 2021

Uh oh!

Uh oh!

kinnison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rbtcollins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xPoe commented May 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xPoe commented May 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kinnison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

0xPoe commented May 27, 2021

Uh oh!

rbtcollins left a comment

Choose a reason for hiding this comment

Uh oh!

rbtcollins May 27, 2021

Choose a reason for hiding this comment

Uh oh!

rbtcollins May 27, 2021

Choose a reason for hiding this comment

Uh oh!

0xPoe commented May 28, 2021

Uh oh!

Reviewers

Assignees

Labels

0xPoe commented May 10, 2021 •

edited

Loading

0xPoe commented May 16, 2021 •

edited

Loading

0xPoe commented May 25, 2021 •

edited

Loading

0xPoe commented May 26, 2021 •

edited

Loading