install: improve heuristic for deprecation warning#2782
Merged
rbtcollins merged 2 commits intorust-lang:masterfrom May 31, 2021
Merged
install: improve heuristic for deprecation warning#2782rbtcollins merged 2 commits intorust-lang:masterfrom
rbtcollins merged 2 commits intorust-lang:masterfrom
Conversation
rbtcollins
reviewed
May 23, 2021
Contributor
rbtcollins
left a comment
rbtcollins
left a comment
There was a problem hiding this comment.
Does can_run get called with self == other ?
perhaps a couple of tests?
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
Contributor
Author
|
Good catch re |
kinnison
force-pushed
the
improve-cross-check
branch
from
651526f to
81df770
Compare
Contributor
Author
|
@rbtcollins If you're okay with this, I'd like to get it merged and then look at doing another staged beta release so that we can get the fixes out soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nominally this will fix #2773 and fix #2765
Basically adjust the heuristic from just "host != target" to account for Windows a little more.