Correctly propagate subshell failures in rustup-init#3012
Merged
kinnison merged 2 commits intorust-lang:masterfrom Jul 16, 2022
Merged
Correctly propagate subshell failures in rustup-init#3012kinnison merged 2 commits intorust-lang:masterfrom
kinnison merged 2 commits intorust-lang:masterfrom
Conversation
kinnison
approved these changes
Jul 16, 2022
Contributor
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
This looks good, thank you for catching this odd corner case
AJ-Ianozi
pushed a commit
to AJ-Ianozi/getada-download
that referenced
this pull request
Oct 12, 2023
Correctly propagate subshell failures in rustup-init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
mktemp -dwere to fail in the current script,rustup-init.shwould report the error but keep running anyway. This fixes that by checking for a nonzero exit status and if so exiting the outer shell.