Fix ambiguous "Proceed with installation" prompt#3673
Merged
djc merged 1 commit intorust-lang:masterfrom Mar 5, 2024
Merged
Conversation
brettearle
changed the title
brettearle
changed the title
Contributor
Author
|
Still a WIP, need to refactor a little |
rami3l
changed the title
Member
|
@brettearle I'm converting this to a draft since you've declared it to be a WIP. Please feel free to convert it back when you're ready :) |
Contributor
Author
|
Alright all done @rami3l, unless you need me to change something :) |
djc
reviewed
Feb 26, 2024
Contributor
Author
|
Ready for review again, happy to change if required :) |
djc
reviewed
Feb 26, 2024
djc
reviewed
Feb 26, 2024
djc
approved these changes
Feb 27, 2024
Contributor
|
Please squash these changes into a single commit (I usually do this with |
Contributor
Author
|
Sweet as, will do. |
brettearle
force-pushed
the
3429-ambiguous-prompt
branch
from
62822ef to
66ef5cf
Compare
Contributor
Author
|
Gday, Is that rebase done the right way? Just unsure about using force to over write it. |
Contributor
|
Yes, the rebase is great -- thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed test and prompt of default prompt in stdout.
Fix #3429