added feedback to doc flag and doc in terminal when opening browser#3674
added feedback to doc flag and doc in terminal when opening browser#3674rami3l merged 1 commit intorust-lang:masterfrom
Conversation
MrTheSaw
left a comment
There was a problem hiding this comment.
That's the sort of thing I was thinking. Looks good.
|
@brettearle I think with Rustup you can forget about merging the master occasionally: GitHub Merge Queue will do this for you eventually, and doing so now is almost certainly a no-op. |
|
Too easy, I will not merge in future unless git yells on the push 🫸 |
|
Removed the prefix |
djc
left a comment
There was a problem hiding this comment.
Now that I think about it, this should probably go to stderr instead of stdout. Otherwise this looks okay to me.
|
@djc why output it as an error? happy to change just would like to know reasoning as I must be missing some knowledge |
|
stderr is generally what is used for status updates/log-like output to the user; stdout should be used for showing the requested output. |
|
(Please also squash the commits here into a single one.) |
e22d90d to
449300a
Compare
rami3l
left a comment
There was a problem hiding this comment.
#3674 (comment) still needs to be addressed. The current code still prints to stdout.
|
Yeah not sure what happened there. Will sort. |
be93095 to
defd4ca
Compare
Fix #3663