ci(macos): add MACOSX_DEPLOYMENT_TARGET and friends#3710
Merged
Conversation
ehuss
reviewed
Mar 13, 2024
Member
Author
|
@djc Can we merge this now? Thanks a lot :) |
djc
approved these changes
Mar 14, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors https://github.com/rust-lang/rust/blob/e61dcc7a0ac33ef054d76453307124233edcf545/src/ci/github-actions/ci.yml#L540-L552 and https://github.com/rust-lang/rust/blob/e61dcc7a0ac33ef054d76453307124233edcf545/src/ci/github-actions/ci.yml#L586-L605 by setting
build-macos-x86_64's target to macOS 10.12, andbuild-macos-aarch64's target to macOS 11.0.Fixes #3708.
(Am I doing this correctly, @ehuss?)
Concerns
Invite @andersm to download and test the CI build in order to verify the fix (as an ARM64 Mac user I don't get access to older macOS versions).The feedback has been positive.