Add hr to Windows instructions#3750
Merged
rami3l merged 1 commit intorust-lang:masterfrom Mar 30, 2024
Merged
Conversation
Member
|
@pie-flavor Thanks! Since this is a visual design change, maybe you could provide a screenshot for this change for the record? |
Contributor
Author
|
Sure. It currently looks like this: |
rami3l
approved these changes
Mar 30, 2024
Member
rami3l
left a comment
rami3l
left a comment
There was a problem hiding this comment.
Nice work, and thanks again for the help @pie-flavor!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it more visually distinct that there are two different sets of instructions for Windows, in case you are ignoring all of the text and skipping straight to the command. A user on Discord did this and was very confused.