Remove derivative dependency in favor of manual implementation#3763
Merged
Remove derivative dependency in favor of manual implementation#3763
Conversation
rami3l
approved these changes
Apr 9, 2024
Member
rami3l
left a comment
rami3l
left a comment
There was a problem hiding this comment.
It's true that #[derivative(Debug = "ignore")] looks like a very rare case in our codebase and it's not worth including derivative in our workspace for just that.
Let's wait for rust-lang/rust#37009 to land on Rust std one day, if it's possble at all XD
Contributor
|
Its nice to have the compile times improved (potentially - not measured), but this increases cognitive load when changes to the struct are made :(, so I'd really rather we solved that by choosing a non-syn backed crate, rather than removing the proc-macro entirely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an added benefit, derivative was the only dependency still relying on syn 1, so this should help compile times.