Skip to content

Use std IsTerminal interface#3765

Merged
djc merged 1 commit intomasterfrom
is-terminal
Apr 9, 2024
Merged

Use std IsTerminal interface#3765
djc merged 1 commit intomasterfrom
is-terminal

Conversation

@djc
Copy link
Copy Markdown
Contributor

@djc djc commented Apr 9, 2024

Was added to std in 1.70.

@djc djc requested a review from rami3l April 9, 2024 13:59
Copy link
Copy Markdown
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

... do we happen to have an MSRV requirement somewhere though?
(I don't see any, so probably everything is fine.)

@djc
Copy link
Copy Markdown
Contributor Author

djc commented Apr 9, 2024

From what I understand we're just relying on stable.

@djc djc added this pull request to the merge queue Apr 9, 2024
Merged via the queue into master with commit fc0385e Apr 9, 2024
@djc djc deleted the is-terminal branch April 9, 2024 15:38
@rbtcollins
Copy link
Copy Markdown
Contributor

From what I understand we're just relying on stable.
Rustup has no library interface, and we don't support targets that aren't reasonably stable themselves yet, so as long as we can build the binary in CI, we're good to pick whatever we want.

In the past I think we even shipped from beta at one point, but for many years now its been stable, with lints checked on beta so we can provide early feedback to candidate lints (which I note @djc / @rami3l have change to be stable too now)

@rami3l rami3l added this to the 1.27.1 milestone Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants