Merged
Conversation
rami3l
approved these changes
Jun 5, 2024
Member
There was a problem hiding this comment.
Looks legit, as long as this doesn't make certain tests harder to perform :)
Eventually I think we can use this to completely get rid of
utils::current_dir()andProcess::current_dir()in favor of passing down thecurrent_dirfrom the originalmain()inrustup-init.rs, but that last step is triggering some weird stuff that needs more investigation.
Would you mind sharing more info regarding this point?
Contributor
Author
|
If I make all of the changes to remove those functions, I get stack overflows from a whole bunch of tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stores the
current_dirinCfgto avoid having to pass it into a number of its methods. Eventually I think we can use this to completely get rid ofutils::current_dir()andProcess::current_dir()in favor of passing down thecurrent_dirfrom the originalmain()inrustup-init.rs, but that last step is triggering some weird stuff that needs more investigation.