implements quiet flag in rustup-init.sh#3910
Merged
rami3l merged 1 commit intorust-lang:masterfrom Jun 30, 2024
vic1707:master
Merged
implements quiet flag in rustup-init.sh#3910rami3l merged 1 commit intorust-lang:masterfrom vic1707:master
rustup-init.sh#3910rami3l merged 1 commit intorust-lang:masterfrom
vic1707:master
Conversation
rami3l
reviewed
Jun 26, 2024
rami3l
reviewed
Jun 26, 2024
Contributor
Author
|
Hi @rami3l may I ask you for an updated review 😁 ? |
rami3l
reviewed
Jun 29, 2024
rami3l
reviewed
Jun 29, 2024
Member
rami3l
left a comment
There was a problem hiding this comment.
Thanks again! You're closer than ever to the finish line :)
rami3l
reviewed
Jun 29, 2024
rami3l
reviewed
Jun 29, 2024
Contributor
Author
|
I think we're good now 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as discussed in #3350