Upload Windows artifacts into correct subdirectory#3934
Merged
jdno merged 1 commit intorust-lang:masterfrom Jul 10, 2024
Merged
Upload Windows artifacts into correct subdirectory#3934jdno merged 1 commit intorust-lang:masterfrom
jdno merged 1 commit intorust-lang:masterfrom
Conversation
The Windows artifacts are uploaded to S3 as part of every build on `master`, but due to slight differences in the upload command syntax between Linux and Windows currently end up at the root of the upload directory. Similar to the existing upload step for builds on `stable`, the command has been tweaked to place the files into the `dist` directory. k
djc
reviewed
Jul 10, 2024
djc
approved these changes
Jul 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows artifacts are uploaded to S3 as part of every build on
master, but due to slight differences in the upload command syntax between Linux and Windows currently end up at the root of the upload directory. Similar to the existing upload step for builds onstable, the command has been tweaked to place the files into thedistdirectory.