Skip to content

Remove once_cell dependency and use LazyLock instead#3971

Merged
rami3l merged 1 commit intorust-lang:masterfrom
InfyniteHeap:change-dependency
Jul 31, 2024
Merged

Remove once_cell dependency and use LazyLock instead#3971
rami3l merged 1 commit intorust-lang:masterfrom
InfyniteHeap:change-dependency

Conversation

@InfyniteHeap
Copy link
Copy Markdown

@InfyniteHeap InfyniteHeap commented Jul 30, 2024

Since Rust 1.80.0 was released, which brought LazyCell and LazyLock, plus the only purpose of introducing once_cell was to use Lazy for initializations of static variables, it is good to replace Lazy with LazyLock.

@InfyniteHeap InfyniteHeap reopened this Jul 30, 2024
rami3l
rami3l reviewed Jul 30, 2024
View reviewed changes
rami3l
rami3l reviewed Jul 30, 2024
View reviewed changes
@rami3l
Copy link
Copy Markdown
Member

rami3l commented Jul 30, 2024

The CI failure might have something to do with CentOS 7's EOL on 2024/06/30. I've always wanted to use cross for our cross-build tests anyway, so might worth a try. I'll probably find some time in the next few weeks to have a look at it if the problem persists...

rami3l
rami3l reviewed Jul 30, 2024
View reviewed changes
@InfyniteHeap
Copy link
Copy Markdown
Author

InfyniteHeap commented Jul 30, 2024

The CI failure might have something to do with CentOS 7's EOL on 2024/06/30. I've always wanted to use cross for our cross-build tests anyway, so might worth a try. I'll probably find some time in the next few weeks to have a look at it if the problem persists...

Ok, and it seems that I have to continue awaiting until this CI issue is resolved...

rami3l
rami3l approved these changes Jul 31, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@InfyniteHeap Looks like the CI is back online. Just squash your commits into one (read more about atomic commits here), and we're good to go.

@InfyniteHeap InfyniteHeap reopened this Jul 31, 2024
@rami3l rami3l enabled auto-merge July 31, 2024 03:38
@rami3l rami3l added this pull request to the merge queue Jul 31, 2024
Merged via the queue into rust-lang:master with commit d5209e1 Jul 31, 2024
@rami3l
Copy link
Copy Markdown
Member

rami3l commented Jul 31, 2024

@InfyniteHeap Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rami3l rami3l rami3l approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@InfyniteHeap @rami3l
⚡