Merged
Conversation
This makes hyper use the platform TLS on Windows and OS X, and adds hostname validation on all platforms.
Contributor
Author
|
It appears that rust-crypto has a native component that's failing the build. I'll find a sha256 implementation that doesn't. |
src/rustup-utils/src/lib.rs
Outdated
| @@ -1,13 +1,15 @@ | |||
| #![feature(core_intrinsics)] // For type_name(). | |||
| #![feature(fundamental)] | |||
| #![feature(step_by)] | |||
Member
There was a problem hiding this comment.
:( I thought we wanted to go the other way
Contributor
Author
There was a problem hiding this comment.
Yeah, it just happened to be used by the sha code and didn't seem worth messing with, but it should be easy to remove. I'll look at it.
Member
|
Nice! r+ from me basically, but looks like the openssl crate is still getting compiled on MinGW which is causing a build failure. Maybe something's bringing it in by accident? |
Passing this call through seems like the safe thing to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #243, fixes #204, #344
r? @alexcrichton cc @sfackler @seanmonstar