Conversation
Contributor
Author
Contributor
|
This looks really cool. I love the way this emphasizes key info. Here are the things I noticed from just running it:
I'll give the code a review seperately. |
Contributor
|
It looks like the markdown parsing is not applied to the post-install and pre-uninstall messages. |
Contributor
|
Otherwise this lgtm. Very nice. |
Contributor
|
r=me with the markdown processing applied to all the messages and with the bots passing. This will break tests in cli-install-interactive for sure. |
Contributor
Author
|
That should be everything (just waiting on tests) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

term2markdownto parse markdown-style text and display formatted output in the terminalThe markdown crate exposes a
tokenizemethod which seems to be exactly fit for purpose. However, it exposes a private type in the return value which makes it unusable. I've opened an issue about it, but for the moment I've had to fork it and use a git dependency.r? @brson